Re: [PATCH] KVM: Fix MAXPHYADDR calculation when cpuid does not support it

[Avi Kivity <avi@redhat.com>]

On 04/11/2010 04:53 PM, Pekka Enberg wrote:
> Avi Kivity wrote:
>> On 04/11/2010 04:45 PM, Pekka Enberg wrote:
>>> Pekka Enberg wrote:
>>>> Avi Kivity wrote:
>>>>>> Hmm, doesn't seem to work here. I still that triple fault in guest.
>>>>>
>>>>> Can you add a printk to see what value is returned and why?
>>>>
>>>> Argh, it's a off-by one bug in my userspace tool... So the CPU 
>>>> really does support 0x80000008 and I'm just an idiot. :-)
>>>
>>> So to explain this a bit more: I'm setting 0x80000000 to 0x80000008 
>>> but failing to install an entry for 0x80000008. I don't quite 
>>> understand why kvm_find_cpuid_entry() doesn't return NULL in this case?
>>
>> cpuid is defined to return the highest entry if it doesn't find a match.
>
> OK, then it's a bug of my own doing and we don't need to do anything 
> in the kernel.

I think the patch is nevertheless correct, not sure why it worked so far.

-- 
error compiling committee.c: too many arguments to function