From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] KVM: Fix MAXPHYADDR calculation when cpuid does not support it Date: Sun, 11 Apr 2010 16:59:00 +0300 Message-ID: <4BC1D5A4.3020703@cs.helsinki.fi> References: <1270989212-3117-1-git-send-email-avi@redhat.com> <4BC1CF54.4020804@cs.helsinki.fi> <4BC1CFBC.5060406@redhat.com> <4BC1D005.5090203@cs.helsinki.fi> <4BC1D26E.9080706@cs.helsinki.fi> <4BC1D339.20704@redhat.com> <4BC1D443.4010702@cs.helsinki.fi> <4BC1D4E5.6070100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from courier.cs.helsinki.fi ([128.214.9.1]:52989 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033Ab0DKN7G (ORCPT ); Sun, 11 Apr 2010 09:59:06 -0400 In-Reply-To: <4BC1D4E5.6070100@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: >> OK, then it's a bug of my own doing and we don't need to do anything >> in the kernel. > > I think the patch is nevertheless correct, not sure why it worked so far. Yes, agreed. I'm guessing most 64-bit CPUs support 0x80000008 and qemu does the right thing so the bug doesn't trigger in practice. Acked-by: Pekka Enberg