From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync Date: Mon, 12 Apr 2010 11:32:53 +0300 Message-ID: <4BC2DAB5.4030901@redhat.com> References: <4BC2D2E2.1030604@cn.fujitsu.com> <4BC2D390.7050708@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , KVM list , LKML To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24318 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372Ab0DLIdA (ORCPT ); Mon, 12 Apr 2010 04:33:00 -0400 In-Reply-To: <4BC2D390.7050708@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/12/2010 11:02 AM, Xiao Guangrong wrote: > - 'vcpu' is not used while mark parent unsync, so remove it > - if it has alread marked unsync, no need to walk it's parent > > Please separate these two changes. The optimization looks good. Perhaps it can be done even nicer using mutually recursive functions (mmu_parent_walk calls mmu_parent_walk_fn which calls mmu_parent_walk on the parent), but let's not change too many things at a time. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.