Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync

Xiao Guangrong
2010-04-14T03:58:35Z

Xiao Guangrong wrote:
>
> Actually, the origin code has a bug, the code segment in mmu_parent_walk():
>
> | if (!sp->multimapped && sp->parent_pte) {
> | ......
> | return;
> | }
> | hlist_for_each_entry(pte_chain, node, &sp->parent_ptes, link)
> | for (i = 0; i < NR_PTE_CHAIN_ENTRIES; ++i) {
> | ......
> | }
>
> So, if sp->parent_pte == NULL, it's unsafe...

Marcelo, please ignore this, it not a bug, just my mistake, sorry...