From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync Date: Mon, 12 Apr 2010 16:55:08 +0800 Message-ID: <4BC2DFEC.5020204@cn.fujitsu.com> References: <4BC2D2E2.1030604@cn.fujitsu.com> <4BC2D390.7050708@cn.fujitsu.com> <4BC2DAB5.4030901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , KVM list , LKML To: Avi Kivity Return-path: In-Reply-To: <4BC2DAB5.4030901@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > On 04/12/2010 11:02 AM, Xiao Guangrong wrote: >> - 'vcpu' is not used while mark parent unsync, so remove it >> - if it has alread marked unsync, no need to walk it's parent >> >> > > Please separate these two changes. > > The optimization looks good. Perhaps it can be done even nicer using > mutually recursive functions (mmu_parent_walk calls mmu_parent_walk_fn > which calls mmu_parent_walk on the parent), but let's not change too > many things at a time. OK, i'll separate it in the next version Thanks, Xiao