From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC 3/5] KVM: Use rapper functions to create and destroy dirty bitmaps Date: Mon, 12 Apr 2010 12:13:34 +0300 Message-ID: <4BC2E43E.3080804@redhat.com> References: <20100409182732.857de4db.yoshikawa.takuya@oss.ntt.co.jp> <20100409183414.f1caa95c.yoshikawa.takuya@oss.ntt.co.jp> <4BC20342.9080800@redhat.com> <4BC2806F.9010707@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, fernando@oss.ntt.co.jp To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2564 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734Ab0DLJNl (ORCPT ); Mon, 12 Apr 2010 05:13:41 -0400 In-Reply-To: <4BC2806F.9010707@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 04/12/2010 05:07 AM, Takuya Yoshikawa wrote: > (2010/04/12 2:13), Avi Kivity wrote: >> On 04/09/2010 12:34 PM, Takuya Yoshikawa wrote: >>> For x86, we will change the allocation and free parts to do_mmap() and >>> do_munmap(). This patch makes it cleaner. >>> >> >> Should be done for all architectures. I don't want different ways of >> creating dirty bitmaps for different architectures. >> > > OK. So the only difference for other(generic) implementation would be > if we pin bitmaps or not. Well, ppc shouldn't need to pin the bitmap either, I'd think. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.