From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, fernando@oss.ntt.co.jp
Subject: Re: [PATCH RFC 4/5] KVM: add new members to the memory slot for double buffering of bitmaps
Date: Mon, 12 Apr 2010 12:19:41 +0300 [thread overview]
Message-ID: <4BC2E5AD.4020207@redhat.com> (raw)
In-Reply-To: <4BC28257.2080003@oss.ntt.co.jp>
On 04/12/2010 05:15 AM, Takuya Yoshikawa wrote:
>
> OK, but we have one problem: ia64. I checked all architectures' dirty
> bitmap
> implementations and thought generalizing this work is not so hard
> except for
> ia64. It's already too different from other parts.
>
> #ifdef CONFIG_IA64
> unsigned long *dirty_bitmap;
> #else
> ...
> #endif
>
> is acceptable?
I think you can keep the bitmap in userspace, but replace the vmalloc()
with get_user_pages() and vmap() (in arch/ia64). 'dirty_bitmap' can
then be in kvm->arch.
Note: this will likely break ia64 without testing. Please copy the
patches to kvm-ia64@vger.kernel.org so they can test and fix them if
they want to.
The patches should at least build, though. If you don't have an ia64
machine, I can build-test them for you.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-04-12 9:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 9:27 [PATCH RFC 0/5] KVM: Moving dirty bitmaps to userspace: double buffering approach Takuya Yoshikawa
2010-04-09 9:30 ` [PATCH RFC 1/5] KVM: introduce a set_bit function for bitmaps in user space Takuya Yoshikawa
2010-04-11 17:08 ` Avi Kivity
2010-04-12 1:29 ` Takuya Yoshikawa
2010-04-12 9:12 ` Avi Kivity
2010-04-21 4:56 ` Fernando Luis Vázquez Cao
2010-04-21 8:09 ` Avi Kivity
2010-04-09 9:32 ` [PATCH RFC 2/5] KVM: use a rapper function to calculate the sizes of dirty bitmaps Takuya Yoshikawa
2010-04-11 17:12 ` Avi Kivity
2010-04-12 1:53 ` Takuya Yoshikawa
2010-04-09 9:34 ` [PATCH RFC 3/5] KVM: Use rapper functions to create and destroy " Takuya Yoshikawa
2010-04-11 17:13 ` Avi Kivity
2010-04-12 2:07 ` Takuya Yoshikawa
2010-04-12 9:13 ` Avi Kivity
2010-04-09 9:35 ` [PATCH RFC 4/5] KVM: add new members to the memory slot for double buffering of bitmaps Takuya Yoshikawa
2010-04-11 17:15 ` Avi Kivity
2010-04-12 2:15 ` Takuya Yoshikawa
2010-04-12 9:19 ` Avi Kivity [this message]
2010-04-12 9:30 ` Takuya Yoshikawa
2010-04-09 9:38 ` [PATCH RFC 5/5] KVM: This is the main part of the "moving dirty bitmaps to user space" Takuya Yoshikawa
2010-04-11 17:21 ` Avi Kivity
2010-04-12 2:29 ` Takuya Yoshikawa
2010-04-12 9:22 ` Avi Kivity
2010-04-12 20:55 ` Fernando Luis Vazquez Cao
2010-04-12 21:00 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC2E5AD.4020207@redhat.com \
--to=avi@redhat.com \
--cc=fernando@oss.ntt.co.jp \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox