From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] get rid of mmu_only parameter in emulator_write_emulated() Date: Tue, 13 Apr 2010 12:21:37 +0300 Message-ID: <4BC437A1.2020208@redhat.com> References: <20100413072156.GF23554@redhat.com> <4BC41C38.5080403@redhat.com> <20100413072643.GG23554@redhat.com> <4BC41ED9.1000506@redhat.com> <20100413074059.GH23554@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45667 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158Ab0DMJVj (ORCPT ); Tue, 13 Apr 2010 05:21:39 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3D9LclN022971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Apr 2010 05:21:38 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3D9LbfT020748 for ; Tue, 13 Apr 2010 05:21:38 -0400 In-Reply-To: <20100413074059.GH23554@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/13/2010 10:40 AM, Gleb Natapov wrote: > The code path executed in case of cmpxchg crossing page boundary is not > touched by the patch as far as I can see. In this case > emulator_write_emulated() is executed with mmu_only false and > kvm_mmu_pte_write() is called from emulator_write_phys(). > > Yes. Patch is correct. -- error compiling committee.c: too many arguments to function