From mboxrd@z Thu Jan 1 00:00:00 1970 From: Naphtali Sprei Subject: [PATCH] qemu-kvm: emulator tests: fix msr test Date: Tue, 13 Apr 2010 17:26:47 +0300 Message-ID: <4BC47F27.4010509@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973Ab0DMO0u (ORCPT ); Tue, 13 Apr 2010 10:26:50 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3DEQok8027398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Apr 2010 10:26:50 -0400 Sender: kvm-owner@vger.kernel.org List-ID: use correct 64 bit mode inline assembly constraints use a canonical form address when writing to the MSR_KERNEL_GS_BASE MSR Signed-off-by: Naphtali Sprei --- kvm/user/test/x86/msr.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/kvm/user/test/x86/msr.c b/kvm/user/test/x86/msr.c index 92102fa..0d6f286 100644 --- a/kvm/user/test/x86/msr.c +++ b/kvm/user/test/x86/msr.c @@ -17,23 +17,25 @@ static void report(const char *name, int passed) static void wrmsr(unsigned index, unsigned long long value) { - asm volatile ("wrmsr" : : "c"(index), "A"(value)); + unsigned a = value, d = value >> 32; + + asm volatile("wrmsr" : : "a"(a), "d"(d), "c"(index)); } static unsigned long long rdmsr(unsigned index) { - unsigned long long value; - - asm volatile ("rdmsr" : "=A"(value) : "c"(index)); + unsigned a, d; - return value; + asm volatile("rdmsr" : "=a"(a), "=d"(d) : "c"(index)); + return ((unsigned long long)d << 32) | a; } + #endif static void test_kernel_gs_base(void) { #ifdef __x86_64__ - unsigned long long v1 = 0x123456789abcdef, v2; + unsigned long long v1 = 0x0000123456789abc, v2; wrmsr(MSR_KERNEL_GS_BASE, v1); v2 = rdmsr(MSR_KERNEL_GS_BASE); -- 1.6.3.3