From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: KVM: x86: Push potential exception error code on task switches
Date: Wed, 14 Apr 2010 15:22:36 +0300
Message-ID: <4BC5B38C.2040500@redhat.com>
References: <4BC5B0FB.8020700@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
	Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:40484 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751440Ab0DNMWk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 14 Apr 2010 08:22:40 -0400
In-Reply-To: <4BC5B0FB.8020700@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/14/2010 03:11 PM, Jan Kiszka wrote:
> When a fault triggers a task switch, the error code, if it exists, has
> to be pushed on the new task's stack. Implement the missing bits.
>
>
> @@ -2416,12 +2417,23 @@ static int emulator_do_task_switch(struct x86_emulate_ctxt *ctxt,
>   	ops->set_cached_descriptor(&next_tss_desc, VCPU_SREG_TR, ctxt->vcpu);
>   	ops->set_segment_selector(tss_selector, VCPU_SREG_TR, ctxt->vcpu);
>
> +	if (ret == X86EMUL_CONTINUE&&  has_error_code) {
> +		struct decode_cache *c =&ctxt->decode;
> +
> +		c->op_bytes = c->ad_bytes = (next_tss_desc.type&  8) ? 4 : 2;
>    

Don't these depend on the attributes of the segment as well?

> +		c->lock_prefix = 0;
> +		c->src.val = (unsigned long) error_code;
> +		emulate_push(ctxt);
> +		ret = writeback(ctxt, ops);
> +	}
> +
>   	return ret;
>   }
>
>    

-- 
error compiling committee.c: too many arguments to function