From: Avi Kivity <avi@redhat.com>
To: oerg Roedel <joro@8bytes.org>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Sheng Yang <sheng@linux.intel.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Gleb Natapov <gleb@redhat.com>,
Zachary Amsden <zamsden@redhat.com>,
zhiteng.huang@intel.com, tim.c.chen@intel.com,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH V3] perf & kvm: Enhance perf to collect KVM guest os statistics from host side
Date: Thu, 15 Apr 2010 12:09:28 +0300 [thread overview]
Message-ID: <4BC6D7C8.9060302@redhat.com> (raw)
In-Reply-To: <20100415090403.GA12697@8bytes.org>
On 04/15/2010 12:04 PM, oerg Roedel wrote:
> On Mon, Apr 15, 2030 at 04:57:38PM +0800, Zhang, Yanmin wrote:
>
>
>> I checked svm.c and it seems svm.c doesn't trigger a NMI to host if the NMI
>> happens in guest os. In addition, svm_complete_interrupts is called after
>> interrupt is enabled.
>>
> Yes. The NMI is held pending by the hardware until the STGI instruction
> is executed.
> And for nested svm the svm_complete_interrupts function needs to be
> executed after the nested exit handling. Therefore it is done late on
> svm.
>
So, we'd need something like the following:
if (exit == NMI)
__get_cpu_var(nmi_vcpu) = vcpu;
stgi();
if (exit == NMI) {
while (!nmi_handled())
cpu_relax();
__get_cpu_var(nmi_vcpu) = NULL;
}
and no code sharing betweem vmx and svm.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-04-15 9:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 9:06 [PATCH V3] perf & kvm: Enhance perf to collect KVM guest os statistics from host side Zhang, Yanmin
2010-04-14 9:20 ` Avi Kivity
2010-04-14 9:43 ` Sheng Yang
2010-04-14 9:57 ` Avi Kivity
2010-04-14 10:14 ` Sheng Yang
2010-04-14 10:19 ` Avi Kivity
2010-04-14 10:27 ` Sheng Yang
2010-04-14 10:33 ` Avi Kivity
2010-04-14 10:36 ` Sheng Yang
2010-04-14 10:43 ` Ingo Molnar
2010-04-14 11:17 ` Avi Kivity
2010-04-15 1:05 ` Zhang, Yanmin
2010-04-15 8:05 ` Avi Kivity
2010-04-15 8:58 ` Zhang, Yanmin
2010-04-15 9:04 ` oerg Roedel
2010-04-15 9:09 ` Avi Kivity [this message]
2010-04-15 9:44 ` oerg Roedel
2010-04-15 9:48 ` Avi Kivity
2010-04-15 10:40 ` Joerg Roedel
2010-04-15 10:44 ` Avi Kivity
2010-04-15 14:08 ` Sheng Yang
2010-04-17 18:12 ` Avi Kivity
2010-04-19 8:25 ` Avi Kivity
2010-04-20 3:32 ` Sheng Yang
2010-04-20 9:38 ` Avi Kivity
2010-04-15 8:58 ` Zhang, Yanmin
2010-04-15 1:05 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC6D7C8.9060302@redhat.com \
--to=avi@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=gleb@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
--cc=tim.c.chen@intel.com \
--cc=yanmin_zhang@linux.intel.com \
--cc=zamsden@redhat.com \
--cc=zhiteng.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox