public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Leszek Urbanski <tygrys@moo.pl>, kvm@vger.kernel.org
Subject: Re: Huge memory leak in virtio, see kvm-Bugs-2989366
Date: Wed, 21 Apr 2010 10:08:20 +0400	[thread overview]
Message-ID: <4BCE9654.2030604@msgid.tls.msk.ru> (raw)
In-Reply-To: <20100421015803.GV24351@us.ibm.com>

21.04.2010 05:58, Ryan Harper wrote:
> * Leszek Urbanski<tygrys@moo.pl>  [2010-04-20 17:37]:
>> Hi,
>>
>> this is a follow-up to bug 2989366:
>>
>> https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2989366&group_id=180599
>>
>> after extensive debugging with the guys on #kvm it turns out that the leak is
>> in the qemu-kvm userland process, in virtio-blk.
[]
> Is that qemu-kvm 0.12.3 compiled from source? or using the distro
> package?

(i'm not the OP, but we talked with him on irc about the issue)

It's a debian package of qemu-kvm.  There are a couple of cosmetic
and unrelated patches applied to it, with one important to fix the
large iovecs issue.  See

  http://git.debian.org/?p=collab-maint/qemu-kvm.git;a=tree;f=debian/patches;h=25ae313db327faa0559016e40fa6161018eb49f4;hb=caa82cbb176403e88128b4fe2698ff192ea10891

for the complete set of patches in there (it's debian/patches
directory in http://git.debian.org/?p=collab-maint/qemu-kvm.git ,
in v0.12.3+dfsg-4 branch).  The only interesting patch in there
is the avoid_creating_too_large_iovecs_in_multiwrite_merge.patch
one, the rest are not relevant.

> If you drop the -smp 4 part, you could also try plain qemu to eliminate
> if there was a qemu-kvm merge issue.

So basically, upstream qemu now works as good
as qemu-kvm for non-smp guests?

> Also, if you switch to a different guest do you still see the same leak?
> This should help determine if the virtio-blk front end is part of the
> issue.

There are only a few guests which are affected.  So far it is not
really clear what differs them from others: a reinstall of a new
guest with the same components and doing same functions will not
necessary show the leak.

Thanks!

/mjt

  reply	other threads:[~2010-04-21  6:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 22:29 Huge memory leak in virtio, see kvm-Bugs-2989366 Leszek Urbanski
2010-04-20 22:51 ` Alexander Graf
2010-04-21  7:53   ` Leszek Urbanski
2010-04-21  8:25     ` Avi Kivity
2010-04-21  1:58 ` Ryan Harper
2010-04-21  6:08   ` Michael Tokarev [this message]
2010-04-21 13:29     ` Leszek Urbanski
2010-04-21 18:39       ` Stefan Hajnoczi
2010-04-21 14:32     ` Ryan Harper
2010-04-21 18:27       ` [PATCH] block: Free iovec arrays allocated by multiwrite_merge() Stefan Hajnoczi
2010-04-21 18:35         ` Ryan Harper
2010-04-21 18:43           ` Brian Jackson
2010-04-21 19:59           ` Leszek Urbanski
2010-04-21 20:03             ` Ryan Harper
2010-04-21 20:13               ` Leszek Urbanski
2010-04-25 12:36                 ` Avi Kivity
2010-04-25 13:27                   ` Stefan Hajnoczi
2010-04-25 13:35                     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCE9654.2030604@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=kvm@vger.kernel.org \
    --cc=ryanh@us.ibm.com \
    --cc=tygrys@moo.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox