From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC please check] KVM: question about the commit "Use Little Endian for Dirty Bitmap" Date: Wed, 21 Apr 2010 12:26:05 +0300 Message-ID: <4BCEC4AD.6060305@redhat.com> References: <20100421150720.16516cb7.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, agraf@suse.de, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44457 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510Ab0DUJ0L (ORCPT ); Wed, 21 Apr 2010 05:26:11 -0400 In-Reply-To: <20100421150720.16516cb7.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 04/21/2010 09:07 AM, Takuya Yoshikawa wrote: > Hi, Alex, Avi, Marcelo > > I would like to ask you about the commit: > c8240bd6f0b4b1b21ffd36dd44114d05c7afe0c0 "Use Little Endian for Dirty Bitmap" > I pasted a snipet below! > > I am now confused by the Alex's comment to my recent patch: > "change mark_page_dirty() to handle endian issues explicitly" > in which I open-coded the generic___set_le_bit(). > > So please explain me about the commit: > 1. is this really the thing you intended to do? > I think so. > 2. including directly is OK? > -- I made a sample patch to avoid this, see below. > I don't see a problem with it, it is also included from other places. It might be possible to change it to , not sure how the include paths are set out. > 3. or, I misunderstand something about Alex's comment? > I missed the comment. What was it? -- error compiling committee.c: too many arguments to function