public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH][STABLE] KVM: x86: Fix TSS size check for 16-bit tasks
Date: Wed, 21 Apr 2010 13:47:04 +0300	[thread overview]
Message-ID: <4BCED7A8.40403@redhat.com> (raw)
In-Reply-To: <4BCED2AD.5030904@siemens.com>

On 04/21/2010 01:25 PM, Jan Kiszka wrote:
>
>> This (and the exception thing) does not qualify under the usual stable
>> rules (regression or host security: in, otherwise out).  I prefer to
>> delay brining up a new guest for one release rather than risk a
>> regression.  If you have a special requirement for it this can be relaxed.
>>
>>      
> In the end, we have to convince the customer's distro provider to
> include this. It would have been easier with an upstream merge, but it
> also is not impossible without it.
>
> But I'm not 100% convinced that the criteria you mentioned match all the
> merged stable patches. There have been feature fixes before - though
> they had more impact on common guests.

Right, we try to balance risk and pain.

> I can understand your concerns
> regarding the exception fix (which diverges from master after recent
> refactorings), but I can't see what makes this obvious fix problematic.
>    

The TSS fix is indeed trivial.  I'll queue it up.  Nevertheless, even 
trivial fixes have risks.

-- 
error compiling committee.c: too many arguments to function


      reply	other threads:[~2010-04-21 10:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14 14:57 [PATCH][STABLE] KVM: x86: Fix TSS size check for 16-bit tasks Jan Kiszka
2010-04-21  9:16 ` Avi Kivity
2010-04-21 10:25   ` Jan Kiszka
2010-04-21 10:47     ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCED7A8.40403@redhat.com \
    --to=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox