From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space Date: Wed, 21 Apr 2010 14:12:09 +0300 Message-ID: <4BCEDD89.10705@redhat.com> References: <20100420195349.dab60b1d.yoshikawa.takuya@oss.ntt.co.jp> <20100420195913.ac44281c.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org To: Takuya Yoshikawa Return-path: In-Reply-To: <20100420195913.ac44281c.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 04/20/2010 01:59 PM, Takuya Yoshikawa wrote: > We will replace copy_to_user() to copy_in_user() when we move > the dirty bitmaps to user space. > > But sadly, we have copy_in_user() only for 64 bits architectures. > So this function should work as a wrapper to hide ifdefs from outside. > Once we get copy_in_user() for 32 bits architectures, we can remove > this wrapper and use copy_in_user() directly. > I prefer a generic copy_in_user() instead of having multiple paths in kvm. -- error compiling committee.c: too many arguments to function