From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Document mmu Date: Thu, 22 Apr 2010 10:24:00 +0300 Message-ID: <4BCFF990.7020501@redhat.com> References: <1271855361-9279-1-git-send-email-avi@redhat.com> <4BCFF736.4030707@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Karl Vogel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12320 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695Ab0DVHYD (ORCPT ); Thu, 22 Apr 2010 03:24:03 -0400 In-Reply-To: <4BCFF736.4030707@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/22/2010 10:13 AM, Karl Vogel wrote: > Avi Kivity wrote: >> +Translation >> +=========== >> + >> +The primary job of the mmu is to program the processor's mmu to >> translate >> +addresses for the guest. Different translations are required at >> different >> +times: >> + >> +- when guest paging is disabled, we translate guest physical >> addresses to >> + host physical addresses (gpa->hpa) >> +- when guest paging is enabled, we translate guest virtual >> addresses, to >> + guest virtual addresses, to host physical addresses (gva->gpa->hpa) > > I think you meant 'to guest physical addresses' here. > Fixed. -- error compiling committee.c: too many arguments to function