Re: [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space

Avi Kivity
2010-04-21T11:12:09Z

On 04/20/2010 01:59 PM, Takuya Yoshikawa wrote:
> We will replace copy_to_user() to copy_in_user() when we move
> the dirty bitmaps to user space.
>
> But sadly, we have copy_in_user() only for 64 bits architectures.
> So this function should work as a wrapper to hide ifdefs from outside.
> Once we get copy_in_user() for 32 bits architectures, we can remove
> this wrapper and use copy_in_user() directly.
>

I prefer a generic copy_in_user() instead of having multiple paths in kvm.

--
error compiling committee.c: too many arguments to function