From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/10] KVM MMU: don't write-protect if have new mapping to unsync page Date: Fri, 23 Apr 2010 14:35:42 +0300 Message-ID: <4BD1860E.7000103@redhat.com> References: <4BCFE581.8050305@cn.fujitsu.com> <4BCFE8F0.7010509@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , KVM list , LKML To: Xiao Guangrong Return-path: In-Reply-To: <4BCFE8F0.7010509@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/22/2010 09:13 AM, Xiao Guangrong wrote: > If have new mapping to the unsync page(i.e, add a new parent), just > update the page from sp->gfn but not write-protect gfn, and if need > create new shadow page form sp->gfn, we should sync it > Sorry, I don't understand this patch. Can you clarify? for example, the situation before adding the new parent, what the guest action was, and the new situation. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.