From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/10] KVM MMU: Move invlpg code out of paging_tmpl.h Date: Fri, 23 Apr 2010 14:43:07 +0300 Message-ID: <4BD187CB.5090701@redhat.com> References: <4BCFE3D5.5070105@cn.fujitsu.com> <4BCFE8E2.8080302@cn.fujitsu.com> <4BD18410.6030509@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , KVM list , LKML To: Xiao Guangrong Return-path: In-Reply-To: <4BD18410.6030509@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/23/2010 02:27 PM, Avi Kivity wrote: > On 04/22/2010 09:12 AM, Xiao Guangrong wrote: >> Using '!sp->role.cr4_pae' replaces 'PTTYPE == 32' and using >> 'pte_size = sp->role.cr4_pae ? 8 : 4' replaces sizeof(pt_element_t) >> >> Then no need compile twice for this code >> > I think we should keep it in - kvm_mmu_pte_write() calls back to > FNAME(update_pte), we could make the call directly from here speed > things up, since we already have the spte and don't need to look it up. > I see you do this in patches 9, 10 - but is it possible to use update_pte directly? I think we'll need to make guess_page_from_pte_write() part of paging_tmpl.h (in general anything that depends on pte size is better off in paging_tmpl.h). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.