From: Chris Lalancette <clalance@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"Yang, Sheng" <sheng.yang@intel.com>, kvm <kvm@vger.kernel.org>,
"bonenkamp@gmx.de" <bonenkamp@gmx.de>,
Chris Wright <chrisw@redhat.com>
Subject: Re: [UNTESTED] KVM: do not call kvm_set_irq from irq disabled section
Date: Fri, 23 Apr 2010 09:02:06 -0400 [thread overview]
Message-ID: <4BD19A4E.2020402@redhat.com> (raw)
In-Reply-To: <4BD17F0D.5070201@redhat.com>
On 04/23/2010 07:05 AM, Avi Kivity wrote:
> On 04/22/2010 10:55 PM, Gleb Natapov wrote:
>>
>>
>>>> What about converting PIC/IOAPIC mutexes into spinlocks?
>>>>
>>> Works for me, but on large guests the spinning will be noticeable.
>>> I believe.
>>>
>> For interrupts going through IOPIC, but we know this is not scalable
>> anyway.
>>
>
> Yes. We also wanted to convert the ioapic/pic to spinlocks so we could
> queue the interrupt from the PIT directly instead of using
> KVM_REQ_PENDING_TIMER which keeps confusing me. Chris Lalancette posted
> a patchset for this a while back but it was never completed.
Yeah, I'm sorry I never completed it. It turns out that with the HPET
changes that went in around the time I was looking at it, that set of
patches wasn't really required to fix the problem I was seeing with kdump.
That being said, if it's useful to somebody, I can repost the patches
(though they are woefully out-of-date now). Let me know if you want
to see them again.
--
Chris Lalancette
next prev parent reply other threads:[~2010-04-23 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 15:54 [UNTESTED] KVM: do not call kvm_set_irq from irq disabled section Marcelo Tosatti
2010-04-20 21:49 ` Bonenkamp, Ralf
2010-04-21 7:51 ` Yang, Sheng
2010-04-21 7:48 ` Yang, Sheng
2010-04-21 15:58 ` Marcelo Tosatti
2010-04-21 17:12 ` Gleb Natapov
2010-04-21 17:37 ` Marcelo Tosatti
2010-04-21 17:58 ` Gleb Natapov
2010-04-21 18:29 ` Marcelo Tosatti
2010-04-21 18:38 ` Gleb Natapov
2010-04-22 16:40 ` Marcelo Tosatti
2010-04-22 18:11 ` Gleb Natapov
2010-04-22 19:40 ` Marcelo Tosatti
2010-04-22 19:55 ` Gleb Natapov
2010-04-23 11:05 ` Avi Kivity
2010-04-23 13:02 ` Chris Lalancette [this message]
2010-04-23 13:30 ` Avi Kivity
2010-04-23 17:03 ` KVM: convert ioapic lock to spinlock Marcelo Tosatti
2010-04-21 8:32 ` [UNTESTED] KVM: do not call kvm_set_irq from irq disabled section Avi Kivity
2010-04-21 16:03 ` Marcelo Tosatti
2010-04-21 16:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD19A4E.2020402@redhat.com \
--to=clalance@redhat.com \
--cc=avi@redhat.com \
--cc=bonenkamp@gmx.de \
--cc=chrisw@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox