From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [RFC PATCH 00/20] Kemari for KVM v0.1 Date: Fri, 23 Apr 2010 08:10:08 -0500 Message-ID: <4BD19C30.9020807@linux.vnet.ibm.com> References: <1271829445-5328-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4BD0A6A5.7000106@linux.vnet.ibm.com> <4BD0ED8D.9080006@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com, Anthony Liguori , mtosatti@redhat.com, ohmura.kei@lab.ntt.co.jp, yoshikawa.takuya@oss.ntt.co.jp To: Yoshiaki Tamura Return-path: Received: from e39.co.us.ibm.com ([32.97.110.160]:52722 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757344Ab0DWNKR (ORCPT ); Fri, 23 Apr 2010 09:10:17 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e39.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o3ND1ocP031002 for ; Fri, 23 Apr 2010 07:01:50 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id o3NDABpN055240 for ; Fri, 23 Apr 2010 07:10:12 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o3NDAAAT029426 for ; Fri, 23 Apr 2010 07:10:10 -0600 In-Reply-To: <4BD0ED8D.9080006@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 04/22/2010 07:45 PM, Yoshiaki Tamura wrote: > Anthony Liguori wrote: > >> I think it would make sense to separate out the things that are actually >> optimizations (like the dirty bitmap changes and the writev/readv >> changes) and to attempt to justify them with actual performance data. > > I agree with the separation plan. > > For dirty bitmap change, Avi and I discussed on patchset for upsream > QEMU while you were offline (Sorry, if I was wrong). Could you also > take a look? Yes, I've seen it and I don't disagree. That said, there ought to be perf data in the commit log so that down the road, the justification is understood. > http://lists.gnu.org/archive/html/qemu-devel/2010-04/msg01396.html > > Regarding writev, I agree that it should be backed with actual data, > otherwise it should be removed. We attemped to do everything that may > reduce the overhead of the transaction. > >> I'd prefer not to modify the live migration protocol ABI and it doesn't >> seem to be necessary if we're willing to add options to the -incoming >> flag. We also want to be a bit more generic with respect to IO. > > I totally agree with your approach not to change the protocol ABI. > Can we add an option to -incoming? Like, -incoming ft_mode, for example > Regarding the IO, let me reply to the next message. > >> Otherwise, the series looks very close to being mergable. > > Thank you for your comment on each patch. > > To be honest, I wasn't that confident because I'm a newbie to KVM/QEMU > and struggled for how to implement in an acceptable way. The series looks very good. I'm eager to see this functionality merged. Regards, Anthony Liguori > Thanks, > > Yoshi > >> >> Regards, >> >> Anthony Liguori >> >> >> >