From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/10] KVM MMU: Move invlpg code out of paging_tmpl.h Date: Fri, 23 Apr 2010 16:27:25 +0300 Message-ID: <4BD1A03D.4000008@redhat.com> References: <4BCFE3D5.5070105@cn.fujitsu.com> <4BCFE8E2.8080302@cn.fujitsu.com> <4BD18410.6030509@redhat.com> <4BD187CB.5090701@redhat.com> <4BD19EEC.1030205@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , KVM list , LKML To: Xiao Guangrong Return-path: In-Reply-To: <4BD19EEC.1030205@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/23/2010 04:21 PM, Xiao Guangrong wrote: > > OK, i'll keep invlpg code in paging_tmpl.h and directly call FNAME(update_pte). > > But, i don't see mmu_guess_page_from_pte_write() code depends on pte size. :-( > It doesn't indeed, I misremembered. It's mmu_pte_write_new_pte() (which is no longer needed). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.