From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Sun, 25 Apr 2010 15:33:03 +0300 Message-ID: <4BD4367F.5060307@redhat.com> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45198 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397Ab0DYMdG (ORCPT ); Sun, 25 Apr 2010 08:33:06 -0400 In-Reply-To: <4BD29F22.8020806@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/24/2010 10:34 AM, Jan Kiszka wrote: > Marcelo Tosatti wrote: > >> Otherwise there is no way to differentiate between global and slot >> specific logging, so for example >> >> vga dirty log start >> migration start >> migration fail >> >> Disables dirty logging for the vga slot. >> > This is not true (unless there is a bug): Migration logging is tracked > via KVMState::migration_log and vga logging via KVMSlot::flags. Both are > merged in kvm_set_user_memory_region. Thus no such change is required > for upstream. > It's still a good idea. The current API assumes that there will be only one slot-based client (or that multiple clients will keep the refcount themselves). After the bytemap -> multiple bitmaps conversion this can be extended to each client getting its own bitmap (and therefore, s/refcount/list of bitmaps/ and s/!refcount/list_empty()/). -- error compiling committee.c: too many arguments to function