From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Sun, 25 Apr 2010 17:17:55 +0300 Message-ID: <4BD44F13.3070000@redhat.com> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45196 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785Ab0DYOR6 (ORCPT ); Sun, 25 Apr 2010 10:17:58 -0400 In-Reply-To: <4BD44A4D.4060008@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/25/2010 04:57 PM, Jan Kiszka wrote: > >> It's still a good idea. The current API assumes that there will be only >> one slot-based client (or that multiple clients will keep the refcount >> themselves). >> >> After the bytemap -> multiple bitmaps conversion this can be extended to >> each client getting its own bitmap (and therefore, s/refcount/list of >> bitmaps/ and s/!refcount/list_empty()/). >> >> > No concerns if > - there is an existing use case for multiple clients, at least in > qemu-kvm > There isn't. But I don't like hidden breakage. > - the logging API is consistently converted, not just extended > (IOW, migration_log is converted to logging_count) > migration_log needs to remain global, since we want hotplug memory to autostart logging. > - someone signs he checked that current use of start/stop in qemu is > completely symmetrical (I think to remember this used to be not the > case, but I might be wrong) > I remember this too. Marcelo? -- error compiling committee.c: too many arguments to function