From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Sun, 25 Apr 2010 17:41:00 +0300 Message-ID: <4BD4547C.5060907@redhat.com> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> <4BD451D9.4090209@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3310 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132Ab0DYOlE (ORCPT ); Sun, 25 Apr 2010 10:41:04 -0400 In-Reply-To: <4BD451D9.4090209@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/25/2010 05:29 PM, Jan Kiszka wrote: > >> There isn't. But I don't like hidden breakage. >> > It's (so far) an unproblematic API property we can document. I don't > like changing APIs just for "there might be the case that...". > I guess it's one of those agree to disagree things. I dislike known broken APIs even if their none of their users are affected. >>> - the logging API is consistently converted, not just extended >>> (IOW, migration_log is converted to logging_count) >>> >>> >> migration_log needs to remain global, since we want hotplug memory to >> autostart logging. >> > Can't follow yet, what will be the usage pattern of > kvm_set_migration_log? Or would the hotplug code require a separate > interface? Is it already the multi-client use case I'm looking for? > kvm_set_migration_log() means, start logging now for all current and future memory, until disabled. It could be implemented in terms of kvm_log_start() (which would provide a multi-client use case), but it isn't now. I guess it is a logical example of how two clients can exist, even though they don't step on each others toes in practice since their enable flags are kept separate by the implementation. -- error compiling committee.c: too many arguments to function