From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Sun, 25 Apr 2010 17:07:02 +0200 Message-ID: <4BD45A96.3080800@web.de> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> <4BD451D9.4090209@web.de> <4BD4547C.5060907@redhat.com> <4BD45709.9070705@web.de> <4BD458AD.9020500@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA82AD8129B4CB19A3F074590" Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:49427 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612Ab0DYPHL (ORCPT ); Sun, 25 Apr 2010 11:07:11 -0400 In-Reply-To: <4BD458AD.9020500@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA82AD8129B4CB19A3F074590 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 04/25/2010 05:51 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> =20 >>> On 04/25/2010 05:29 PM, Jan Kiszka wrote: >>> =20 >>>> =20 >>>>> There isn't. But I don't like hidden breakage. >>>>> >>>>> =20 >>>> It's (so far) an unproblematic API property we can document. I don't= >>>> like changing APIs just for "there might be the case that...". >>>> >>>> =20 >>> I guess it's one of those agree to disagree things. I dislike known >>> broken APIs even if their none of their users are affected. >>> =20 >> The API is not broken. I intentionally designed it for the single user= >> as I saw no need for more. If I oversaw something, I would really like= >> to learn about these cases. >> =20 >=20 > The fact that the API assumes a single user is what's broken IMO. >=20 > If the API were to take a memory slot as parameter you could say it is > the responsibility of the slot's owner to multiplex (and since vga has = a > single owner, no need to multiplex). But it takes a range. No, the API accepts only a single slot. If you try passing bogus ranges that span multiple or incomplete slots, you get what you deserve - a bug message. Jan --------------enigA82AD8129B4CB19A3F074590 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkvUWp0ACgkQitSsb3rl5xQqpQCgyrzAFUAv8/WGeILSKdlrQx89 NaEAn2XbzdVZVpsdylPkSZ9x/1cQto6Z =7kYq -----END PGP SIGNATURE----- --------------enigA82AD8129B4CB19A3F074590--