From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Sun, 25 Apr 2010 18:22:26 +0300 Message-ID: <4BD45E32.1070406@redhat.com> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> <4BD451D9.4090209@web.de> <4BD4547C.5060907@redhat.com> <4BD45709.9070705@web.de> <4BD458AD.9020500@redhat.com> <4BD45A96.3080800@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796Ab0DYPW3 (ORCPT ); Sun, 25 Apr 2010 11:22:29 -0400 In-Reply-To: <4BD45A96.3080800@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/25/2010 06:07 PM, Jan Kiszka wrote: > >> The fact that the API assumes a single user is what's broken IMO. >> >> If the API were to take a memory slot as parameter you could say it is >> the responsibility of the slot's owner to multiplex (and since vga has a >> single owner, no need to multiplex). But it takes a range. >> > No, the API accepts only a single slot. If you try passing bogus ranges > that span multiple or incomplete slots, you get what you deserve - a bug > message. > I see. In its qemu-kvm iteration, it would iterate over slots and accept incomplete slots (it's okay to log more than requested). If the API is for a slot, it should accept a slot, not a range (when we move to a slots representation in qemu). Unrelated: cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa0000, 0xa8000); cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa8000, 0xb0000); Will this sync to the right place (whatever those windows alias to)? -- error compiling committee.c: too many arguments to function