From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Sun, 25 Apr 2010 18:42:11 +0200 Message-ID: <4BD470E3.9050803@web.de> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> <4BD451D9.4090209@web.de> <4BD4547C.5060907@redhat.com> <4BD45709.9070705@web.de> <4BD458AD.9020500@redhat.com> <4BD45A96.3080800@web.de> <4BD45E32.1070406@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig476E8FE8C1C4C91B3E3B1EEB" Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:56162 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530Ab0DYQmN (ORCPT ); Sun, 25 Apr 2010 12:42:13 -0400 In-Reply-To: <4BD45E32.1070406@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig476E8FE8C1C4C91B3E3B1EEB Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 04/25/2010 06:07 PM, Jan Kiszka wrote: >> >>> The fact that the API assumes a single user is what's broken IMO. >>> >>> If the API were to take a memory slot as parameter you could say it i= s >>> the responsibility of the slot's owner to multiplex (and since vga ha= s a >>> single owner, no need to multiplex). But it takes a range. >>> =20 >> No, the API accepts only a single slot. If you try passing bogus range= s >> that span multiple or incomplete slots, you get what you deserve - a b= ug >> message. >> =20 >=20 > I see. In its qemu-kvm iteration, it would iterate over slots and > accept incomplete slots (it's okay to log more than requested). If the= > API is for a slot, it should accept a slot, not a range (when we move t= o > a slots representation in qemu). Yes, an explicit slot reference in the API would be clearer. >=20 > Unrelated: >=20 > cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa0000, 0xa8000)= ; > cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa8000, 0xb0000)= ; >=20 > Will this sync to the right place (whatever those windows alias to)? >=20 It should. Or where do your worries come from? Jan --------------enig476E8FE8C1C4C91B3E3B1EEB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkvUcOMACgkQitSsb3rl5xT/XACfSE7XJ9LIkPJcJnhaAZRxCBpf /qIAoJcb1xnXJesLVXet2GL5mS2Ef/pO =iNPn -----END PGP SIGNATURE----- --------------enig476E8FE8C1C4C91B3E3B1EEB--