From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots
Date: Mon, 26 Apr 2010 08:37:38 +0300 [thread overview]
Message-ID: <4BD526A2.60703@redhat.com> (raw)
In-Reply-To: <4BD470E3.9050803@web.de>
On 04/25/2010 07:42 PM, Jan Kiszka wrote:
>
>> Unrelated:
>>
>> cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa0000, 0xa8000);
>> cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa8000, 0xb0000);
>>
>> Will this sync to the right place (whatever those windows alias to)?
>>
>>
> It should. Or where do your worries come from?
>
>
I was worried the bitmap was indexed by physical addresses, but now I
remember it is indexed by ram addresses, so it all works out.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-04-26 5:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 17:04 [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code Marcelo Tosatti
2010-04-23 17:04 ` [uq/master patch 1/5] vga: fix typo in length passed to kvm_log_stop Marcelo Tosatti
2010-04-23 17:04 ` [uq/master patch 2/5] kvm: add logging count to slots Marcelo Tosatti
2010-04-24 7:34 ` Jan Kiszka
2010-04-25 12:33 ` Avi Kivity
2010-04-25 13:57 ` Jan Kiszka
2010-04-25 14:17 ` Avi Kivity
2010-04-25 14:29 ` Jan Kiszka
2010-04-25 14:41 ` Avi Kivity
2010-04-25 14:51 ` Jan Kiszka
2010-04-25 14:58 ` Avi Kivity
2010-04-25 15:07 ` Jan Kiszka
2010-04-25 15:22 ` Avi Kivity
2010-04-25 16:42 ` Jan Kiszka
2010-04-26 5:37 ` Avi Kivity [this message]
2010-04-26 13:47 ` Marcelo Tosatti
2010-04-23 17:04 ` [uq/master patch 3/5] introduce leul_to_cpu Marcelo Tosatti
2010-04-23 17:04 ` [uq/master patch 4/5] kvm: port qemu-kvm's bitmap scanning Marcelo Tosatti
2010-04-23 17:04 ` [uq/master patch 5/5] introduce qemu_ram_map Marcelo Tosatti
2010-04-25 12:33 ` [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD526A2.60703@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox