From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Mon, 26 Apr 2010 08:37:38 +0300 Message-ID: <4BD526A2.60703@redhat.com> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> <4BD451D9.4090209@web.de> <4BD4547C.5060907@redhat.com> <4BD45709.9070705@web.de> <4BD458AD.9020500@redhat.com> <4BD45A96.3080800@web.de> <4BD45E32.1070406@redhat.com> <4BD470E3.9050803@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3973 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232Ab0DZFhn (ORCPT ); Mon, 26 Apr 2010 01:37:43 -0400 In-Reply-To: <4BD470E3.9050803@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/25/2010 07:42 PM, Jan Kiszka wrote: > >> Unrelated: >> >> cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa0000, 0xa8000); >> cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa8000, 0xb0000); >> >> Will this sync to the right place (whatever those windows alias to)? >> >> > It should. Or where do your worries come from? > > I was worried the bitmap was indexed by physical addresses, but now I remember it is indexed by ram addresses, so it all works out. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.