From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 10/10] introduce qemu_ram_map Date: Mon, 26 Apr 2010 13:29:06 -0500 Message-ID: <4BD5DB72.3030707@codemonkey.ws> References: <2e085c19aac78e6c4335eac4fffeb5cfca4bbb26.1272304746.git.mtosatti@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, Cam Macdonell To: Marcelo Tosatti Return-path: Received: from mail-px0-f174.google.com ([209.85.212.174]:40460 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715Ab0DZS3L (ORCPT ); Mon, 26 Apr 2010 14:29:11 -0400 Received: by pxi17 with SMTP id 17so1771967pxi.19 for ; Mon, 26 Apr 2010 11:29:10 -0700 (PDT) In-Reply-To: <2e085c19aac78e6c4335eac4fffeb5cfca4bbb26.1272304746.git.mtosatti@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: > Which allows drivers to register an mmaped region into ram block mappings. > To be used by device assignment driver. > > This is not kvm specific and not required by this pull request so it shouldn't really be part of the pull. Something like this should only be added when there's an actual consumer. Regards, Anthony Liguori > CC: Cam Macdonell > Signed-off-by: Marcelo Tosatti > --- > cpu-common.h | 1 + > exec.c | 28 ++++++++++++++++++++++++++++ > 2 files changed, 29 insertions(+), 0 deletions(-) > > diff --git a/cpu-common.h b/cpu-common.h > index b24cecc..2dfde6f 100644 > --- a/cpu-common.h > +++ b/cpu-common.h > @@ -40,6 +40,7 @@ static inline void cpu_register_physical_memory(target_phys_addr_t start_addr, > } > > ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr); > +ram_addr_t qemu_ram_map(ram_addr_t size, void *host); > ram_addr_t qemu_ram_alloc(ram_addr_t); > void qemu_ram_free(ram_addr_t addr); > /* This should only be used for ram local to a device. */ > diff --git a/exec.c b/exec.c > index 14d1fd7..648a9c9 100644 > --- a/exec.c > +++ b/exec.c > @@ -2789,6 +2789,34 @@ static void *file_ram_alloc(ram_addr_t memory, const char *path) > } > #endif > > +ram_addr_t qemu_ram_map(ram_addr_t size, void *host) > +{ > + RAMBlock *new_block; > + > + size = TARGET_PAGE_ALIGN(size); > + new_block = qemu_malloc(sizeof(*new_block)); > + > + new_block->host = host; > + > + new_block->offset = last_ram_offset; > + new_block->length = size; > + > + new_block->next = ram_blocks; > + ram_blocks = new_block; > + > + phys_ram_dirty = qemu_realloc(phys_ram_dirty, > + (last_ram_offset + size)>> TARGET_PAGE_BITS); > + memset(phys_ram_dirty + (last_ram_offset>> TARGET_PAGE_BITS), > + 0xff, size>> TARGET_PAGE_BITS); > + > + last_ram_offset += size; > + > + if (kvm_enabled()) > + kvm_setup_guest_memory(new_block->host, size); > + > + return new_block->offset; > +} > + > ram_addr_t qemu_ram_alloc(ram_addr_t size) > { > RAMBlock *new_block; >