public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: KVM list <kvm@vger.kernel.org>
Subject: apparent key mapping error for usb keyboard
Date: Tue, 27 Apr 2010 13:46:36 +0400	[thread overview]
Message-ID: <4BD6B27C.4060500@msgid.tls.msk.ru> (raw)

I've a debian bugreport that claims to have a fix
for apparently wrong keymap for usb keyboard.  I
noticed this before with ps/2 keyboard too, the
sympthoms were that e.g windows keys were not
working in guests, but later on that has been
fixed.  But with `-usbdevice keyboard', i.e. with
usb keyboard, it still does not work.  See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578846
for details and for the proposed patch which
fixes the mentioned issue.  Here's the patch itself:

--- a/hw/usb-hid.c
+++ b/hw/usb-hid.c
@@ -399,3 +399,3 @@
      0x51, 0x4e, 0x49, 0x4c, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x00, 0x00,
      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

I'm not sure if it's right fix however.  Hence I'm
asking for opinions here.  If it's a right way to go,
it should probably be applied to -stable too.

Thanks!

/mjt

             reply	other threads:[~2010-04-27  9:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27  9:46 Michael Tokarev [this message]
2010-05-04  9:38 ` apparent key mapping error for usb keyboard Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD6B27C.4060500@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox