Re: [PATCH 15/22] KVM: MMU: Introduce kvm_read_guest_page_x86()

Joerg Roedel
2010-04-27T16:28:06Z

On Tue, Apr 27, 2010 at 07:09:37PM +0300, Avi Kivity wrote:
> On 04/27/2010 06:40 PM, Joerg Roedel wrote:
> >
> >Currently its a bit unclear when to use mmu or nested_mmu. With a
> >pointer it would be unclear to the code reader when to use the pointer
> >and when to select the mmu_contexts directly.
>
> I think in most cases you'd want full translation, thus the pointer.
> This should be the default. In specific cases you'd want just the
> non-nested guest translation.

Hmm, for most cases == all gva_to_gpa cases. The page fault path can't
use the pointer. I'll try out how this works. It shouldn't be too
complicated.

Joerg