From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 15/22] KVM: MMU: Introduce kvm_read_guest_page_x86() Date: Tue, 27 Apr 2010 19:09:37 +0300 Message-ID: <4BD70C41.2060202@redhat.com> References: <1272364712-17425-1-git-send-email-joerg.roedel@amd.com> <1272364712-17425-16-git-send-email-joerg.roedel@amd.com> <4BD6DE15.8070409@redhat.com> <20100427132030.GH11097@amd.com> <4BD6E80A.2000201@redhat.com> <20100427154024.GL11097@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920Ab0D0QJk (ORCPT ); Tue, 27 Apr 2010 12:09:40 -0400 In-Reply-To: <20100427154024.GL11097@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/27/2010 06:40 PM, Joerg Roedel wrote: > > Currently its a bit unclear when to use mmu or nested_mmu. With a > pointer it would be unclear to the code reader when to use the pointer > and when to select the mmu_contexts directly. > I think in most cases you'd want full translation, thus the pointer. This should be the default. In specific cases you'd want just the non-nested guest translation. -- error compiling committee.c: too many arguments to function