From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 09/23] KVM: x86 emulator: make set_cr() callback return error if it fails Date: Wed, 28 Apr 2010 12:01:57 +0300 Message-ID: <4BD7F985.9000300@redhat.com> References: <1272370524-1295-1-git-send-email-gleb@redhat.com> <1272370524-1295-10-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60794 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758Ab0D1JB7 (ORCPT ); Wed, 28 Apr 2010 05:01:59 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3S91xet027002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Apr 2010 05:01:59 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3S91wZo013318 for ; Wed, 28 Apr 2010 05:01:58 -0400 In-Reply-To: <1272370524-1295-10-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/27/2010 03:15 PM, Gleb Natapov wrote: > Make set_cr() callback return error if it fails instead of injecting #GP > behind emulator's back. > > > > -void kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0) > +static int _kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0) > { > standard practice is double underscore. -- error compiling committee.c: too many arguments to function