From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 22/23] KVM: remove unneeded initialization. Date: Wed, 28 Apr 2010 12:17:34 +0300 Message-ID: <4BD7FD2E.4020408@redhat.com> References: <1272370524-1295-1-git-send-email-gleb@redhat.com> <1272370524-1295-23-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52867 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830Ab0D1JRg (ORCPT ); Wed, 28 Apr 2010 05:17:36 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3S9HavH024756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Apr 2010 05:17:36 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3S9HY41011194 for ; Wed, 28 Apr 2010 05:17:35 -0400 In-Reply-To: <1272370524-1295-23-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/27/2010 03:15 PM, Gleb Natapov wrote: > This initialization is no longer needed. > > Signed-off-by: Gleb Natapov > --- > arch/x86/kvm/x86.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index ed15b20..29e2d3b 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -3801,8 +3801,6 @@ int emulate_instruction(struct kvm_vcpu *vcpu, > */ > cache_all_regs(vcpu); > > - vcpu->mmio_is_write = 0; > - > if (!(emulation_type& EMULTYPE_NO_DECODE)) { > int cs_db, cs_l; > kvm_x86_ops->get_cs_db_l_bits(vcpu,&cs_db,&cs_l); > Best to fold into the patch that made it unnecessary. -- error compiling committee.c: too many arguments to function