From: Michael Goldish <mgoldish@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 3/9] KVM test: Make the login re suitable for serial console
Date: Wed, 28 Apr 2010 14:18:14 +0300 [thread overview]
Message-ID: <4BD81976.6060303@redhat.com> (raw)
In-Reply-To: <20100426100346.26268.17314.stgit@localhost.localdomain>
On 04/26/2010 01:03 PM, Jason Wang wrote:
> Current matching re ^\s*[Ll]ogin:\s*$ is not suitable for the serial
> console, so change it to [Ll]ogin:.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> client/tests/kvm/kvm_utils.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
> index 1ea0852..bb42314 100644
> --- a/client/tests/kvm/kvm_utils.py
> +++ b/client/tests/kvm/kvm_utils.py
> @@ -488,7 +488,7 @@ def remote_login(command, password, prompt, linesep="\n", timeout=10,
>
> while True:
> (match, text) = sub.read_until_last_line_matches(
> - [r"[Aa]re you sure", r"[Pp]assword:\s*$", r"^\s*[Ll]ogin:\s*$",
> + [r"[Aa]re you sure", r"[Pp]assword:\s*$", r"[Ll]ogin:",
This RE will also match
"Last login: Wed Apr 28 14:07:28 2010 from localhost.localdomain"
so we should probably settle for [Ll]ogin:\s*$.
> r"[Cc]onnection.*closed", r"[Cc]onnection.*refused",
> r"[Pp]lease wait", prompt],
> timeout=timeout, internal_timeout=0.5)
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-28 11:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 10:03 [PATCH 0/9] Make use of the redirection of guest serial Jason Wang
2010-04-26 10:03 ` [PATCH 1/9] KVM test: Introduce the prompt assist Jason Wang
2010-04-28 11:28 ` Michael Goldish
2010-05-06 2:55 ` Jason Wang
2010-05-06 15:18 ` Lucas Meneghel Rodrigues
2010-04-26 10:03 ` [PATCH 2/9] KVM test: Add the ability to send the username in remote_login() Jason Wang
2010-04-28 11:32 ` Michael Goldish
2010-04-26 10:03 ` [PATCH 3/9] KVM test: Make the login re suitable for serial console Jason Wang
2010-04-28 11:18 ` Michael Goldish [this message]
2010-05-06 2:57 ` Jason Wang
2010-04-26 10:03 ` [PATCH 4/9] KVM test: Redirect the serial to the unix domain socket Jason Wang
2010-04-26 10:04 ` [PATCH 5/9] KVM test: Log the content from guest serial console Jason Wang
2010-04-28 13:26 ` Michael Goldish
2010-05-06 3:03 ` Jason Wang
2010-04-26 10:04 ` [PATCH 6/9] KVM test: Raise error when met unknown type in kvm_vm.remote_login() Jason Wang
2010-05-06 15:15 ` [Autotest] " Lucas Meneghel Rodrigues
2010-04-26 10:04 ` [PATCH 7/9] KVM test: Introduce the local_login() Jason Wang
2010-04-28 12:01 ` Michael Goldish
2010-04-28 23:44 ` Amos Kong
[not found] ` <20100428234409.GA2738@akong@redhat.com>
2010-05-05 9:37 ` [Autotest] " Michael Goldish
2010-05-06 3:07 ` Jason Wang
2010-04-26 10:04 ` [PATCH 8/9] KVM test: Create the background threads before calling process() Jason Wang
2010-04-28 11:55 ` Michael Goldish
2010-05-06 15:35 ` [Autotest] " Lucas Meneghel Rodrigues
2010-04-26 10:04 ` [PATCH 9/9] KVM test: Redirect the console to serial for all linux guests Jason Wang
2010-04-28 12:24 ` Michael Goldish
2010-05-06 3:08 ` Jason Wang
2010-05-06 15:43 ` Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD81976.6060303@redhat.com \
--to=mgoldish@redhat.com \
--cc=autotest@test.kernel.org \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).