From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Goldish <mgoldish@redhat.com>
Subject: Re: [PATCH 2/9] KVM test: Add the ability to send the
 username in remote_login()
Date: Wed, 28 Apr 2010 14:32:48 +0300
Message-ID: <4BD81CE0.4060905@redhat.com>
References: <20100426095656.26268.50549.stgit@localhost.localdomain>
	<20100426100338.26268.15473.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
To: Jason Wang <jasowang@redhat.com>
Return-path: <autotest-bounces@test.kernel.org>
In-Reply-To: <20100426100338.26268.15473.stgit@localhost.localdomain>
List-Unsubscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=unsubscribe>
List-Archive: <http://test.kernel.org/pipermail/autotest>
List-Post: <mailto:autotest@test.kernel.org>
List-Help: <mailto:autotest-request@test.kernel.org?subject=help>
List-Subscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=subscribe>
Sender: autotest-bounces@test.kernel.org
Errors-To: autotest-bounces@test.kernel.org
List-Id: kvm.vger.kernel.org

On 04/26/2010 01:03 PM, Jason Wang wrote:
> In order to let the serial console work, we must let the
> remote_login() send the username when needed.
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  client/tests/kvm/kvm_utils.py |   14 ++++++++++----
>  1 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
> index 9adbaee..1ea0852 100644
> --- a/client/tests/kvm/kvm_utils.py
> +++ b/client/tests/kvm/kvm_utils.py
> @@ -452,7 +452,7 @@ def check_kvm_source_dir(source_dir):
>  # guests.
>  
>  def remote_login(command, password, prompt, linesep="\n", timeout=10,
> -                 prompt_assist = None):
> +                 prompt_assist = None, username = None):
                                 ^ ^              ^ ^
Same here: PEP 8 says no spaces around keyword arguments or default
values, and pretty much all of the KVM test code conforms with PEP 8, so
let's be consistent.