From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu
Date: Wed, 28 Apr 2010 10:39:06 -0500
Message-ID: <4BD8569A.1030205@codemonkey.ws>
References: <cover.1272304746.git.mtosatti@redhat.com> <1e7180606d206cc9882d4545cbf1aed29fad8088.1272304746.git.mtosatti@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qy0-f179.google.com ([209.85.221.179]:59386 "EHLO
	mail-qy0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755295Ab0D1Pkz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 28 Apr 2010 11:40:55 -0400
Received: by qyk9 with SMTP id 9so21440945qyk.1
        for <kvm@vger.kernel.org>; Wed, 28 Apr 2010 08:40:54 -0700 (PDT)
In-Reply-To: <1e7180606d206cc9882d4545cbf1aed29fad8088.1272304746.git.mtosatti@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
> This is now done via the initialization's qemu_system_reset call.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>   kvm-all.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 9c8aa7d..eabb097 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env)
>       ret = kvm_arch_init_vcpu(env);
>       if (ret == 0) {
>           qemu_register_reset(kvm_reset_vcpu, env);
> -        kvm_arch_reset_vcpu(env);
>       }
>   err:
>       return ret;
>    

This breaks -enable-kvm in upstream qemu.  No progress is ever made in 
the guest.

Regards,

Anthony Liguori