From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu Date: Wed, 28 Apr 2010 11:46:34 -0500 Message-ID: <4BD8666A.4080109@codemonkey.ws> References: <1e7180606d206cc9882d4545cbf1aed29fad8088.1272304746.git.mtosatti@redhat.com> <4BD8569A.1030205@codemonkey.ws> <20100428162214.GA18168@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity To: Marcelo Tosatti Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:38746 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704Ab0D1Qqj (ORCPT ); Wed, 28 Apr 2010 12:46:39 -0400 Received: by pwj9 with SMTP id 9so10524741pwj.19 for ; Wed, 28 Apr 2010 09:46:39 -0700 (PDT) In-Reply-To: <20100428162214.GA18168@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 04/28/2010 11:22 AM, Marcelo Tosatti wrote: > On Wed, Apr 28, 2010 at 10:39:06AM -0500, Anthony Liguori wrote: > >> On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: >> >>> This is now done via the initialization's qemu_system_reset call. >>> >>> Signed-off-by: Avi Kivity >>> --- >>> kvm-all.c | 1 - >>> 1 files changed, 0 insertions(+), 1 deletions(-) >>> >>> diff --git a/kvm-all.c b/kvm-all.c >>> index 9c8aa7d..eabb097 100644 >>> --- a/kvm-all.c >>> +++ b/kvm-all.c >>> @@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env) >>> ret = kvm_arch_init_vcpu(env); >>> if (ret == 0) { >>> qemu_register_reset(kvm_reset_vcpu, env); >>> - kvm_arch_reset_vcpu(env); >>> } >>> err: >>> return ret; >>> >> This breaks -enable-kvm in upstream qemu. No progress is ever made >> in the guest. >> > These patches have been autotested, and just confirmed manually that > this patch does not break -enable-kvm (as the reset handler is now > called through the notifier). > > What is your qemu command line? > x86_64-softmmu/qemu-system-x86_64 -hda ~/images/linux.img -snapshot -enable-kvm -L ~/git/qemu/pc-bios This is with the very latest tip. I can publish a branch if that's helpful. If you have an old tree, I wouldn't be surprised if it didn't show up. Regards, Anthony Liguori