From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
KVM list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] KVM MMU: do not intercept invlpg if 'oos_shadow' is disabled
Date: Fri, 30 Apr 2010 12:56:26 +0300 [thread overview]
Message-ID: <4BDAA94A.8050407@redhat.com> (raw)
In-Reply-To: <4BDA9D58.6030407@cn.fujitsu.com>
On 04/30/2010 12:05 PM, Xiao Guangrong wrote:
> If 'oos_shadow' == 0, intercepting invlpg command is really
> unnecessary.
>
> And it's good for us to compare the performance between enable 'oos_shadow'
> and disable 'oos_shadow'
>
> @@ -74,8 +74,9 @@ static int dbg = 0;
> module_param(dbg, bool, 0644);
> #endif
>
> -static int oos_shadow = 1;
> +int __read_mostly oos_shadow = 1;
> module_param(oos_shadow, bool, 0644);
> +EXPORT_SYMBOL_GPL(oos_shadow);
>
Please rename to kvm_oos_shadow to reduce potential for conflict with
other global names.
But really, this is a debug option, I don't expect people to run with
oos_shadow=0, so there's not much motivation to optimize it.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-04-30 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BDA9C37.9070602@cn.fujitsu.com>
2010-04-30 9:52 ` [PATCH 1/4] KVM MMU: fix race in invlpg code Avi Kivity
[not found] ` <4BDA9C86.8080204@cn.fujitsu.com>
[not found] ` <4BDA9CD0.6070501@cn.fujitsu.com>
2010-04-30 9:54 ` [PATCH 3/4] KVM MMU: allow shadow page become unsync at creating time Avi Kivity
[not found] ` <4BDA9D58.6030407@cn.fujitsu.com>
2010-04-30 9:56 ` Avi Kivity [this message]
2010-05-05 12:54 ` [PATCH 4/4] KVM MMU: do not intercept invlpg if 'oos_shadow' is disabled Xiao Guangrong
2010-05-05 14:26 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDAA94A.8050407@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox