From: Avi Kivity <avi@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
Brian Gerst <brgerst@gmail.com>,
Dexuan Cui <dexuan.cui@intel.com>,
Sheng Yang <sheng@linux.intel.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: eliminate TS_XSAVE
Date: Tue, 04 May 2010 10:41:19 +0300 [thread overview]
Message-ID: <4BDFCF9F.3030600@redhat.com> (raw)
In-Reply-To: <4BDF4407.8000503@zytor.com>
On 05/04/2010 12:45 AM, H. Peter Anvin wrote:
>
>> I was trying to avoid a performance regression relative to the current
>> code, as it appears that some care was taken to avoid the memory reference.
>>
>> I agree that it's probably negligible compared to the save/restore
>> code. If the x86 maintainers agree as well, I'll replace it with
>> cpu_has_xsave.
>>
>>
> I asked Suresh to comment on this, since he wrote the original code. He
> did confirm that the intent was to avoid a global memory reference.
>
>
Ok, so you're happy with the patch as is?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-05-04 7:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 14:53 [PATCH 0/2] x86 FPU API Avi Kivity
2010-05-02 14:53 ` [PATCH 1/2] x86: eliminate TS_XSAVE Avi Kivity
2010-05-02 17:38 ` Brian Gerst
2010-05-02 17:44 ` Avi Kivity
2010-05-03 21:45 ` H. Peter Anvin
2010-05-04 7:41 ` Avi Kivity [this message]
2010-05-04 18:15 ` Suresh Siddha
2010-05-04 18:24 ` H. Peter Anvin
2010-05-05 7:30 ` Avi Kivity
2010-05-05 12:10 ` H. Peter Anvin
2010-05-05 12:12 ` H. Peter Anvin
2010-05-04 18:03 ` Suresh Siddha
2010-05-02 14:53 ` [PATCH 2/2] x86: Introduce 'struct fpu' and related API Avi Kivity
2010-05-04 18:12 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDFCF9F.3030600@redhat.com \
--to=avi@redhat.com \
--cc=brgerst@gmail.com \
--cc=dexuan.cui@intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sheng@linux.intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox