From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: apparent key mapping error for usb keyboard Date: Tue, 04 May 2010 12:38:17 +0300 Message-ID: <4BDFEB09.3060309@redhat.com> References: <4BD6B27C.4060500@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , qemu-devel To: Michael Tokarev Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24708 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754758Ab0EDJiX (ORCPT ); Tue, 4 May 2010 05:38:23 -0400 In-Reply-To: <4BD6B27C.4060500@msgid.tls.msk.ru> Sender: kvm-owner@vger.kernel.org List-ID: On 04/27/2010 12:46 PM, Michael Tokarev wrote: > I've a debian bugreport that claims to have a fix > for apparently wrong keymap for usb keyboard. I > noticed this before with ps/2 keyboard too, the > sympthoms were that e.g windows keys were not > working in guests, but later on that has been > fixed. But with `-usbdevice keyboard', i.e. with > usb keyboard, it still does not work. See > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578846 > for details and for the proposed patch which > fixes the mentioned issue. Here's the patch itself: > > --- a/hw/usb-hid.c > +++ b/hw/usb-hid.c > @@ -399,3 +399,3 @@ > 0x51, 0x4e, 0x49, 0x4c, 0x00, 0x00, 0x00, 0x00, > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > I'm not sure if it's right fix however. Hence I'm > asking for opinions here. If it's a right way to go, > it should probably be applied to -stable too. I've no idea, but the correct place to ask is qemu-devel (copied). -- error compiling committee.c: too many arguments to function