From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zamsden@redhat.com
Subject: Re: [PATCH v2 6/7] don't compute pvclock adjustments if we trust the tsc
Date: Wed, 05 May 2010 11:28:11 +0300 [thread overview]
Message-ID: <4BE12C1B.8070409@redhat.com> (raw)
In-Reply-To: <1272901927-829-7-git-send-email-glommer@redhat.com>
On 05/03/2010 06:52 PM, Glauber Costa wrote:
> If the HV told us we can fully trust the TSC, skip any
> correction
>
>
> Signed-off-by: Glauber Costa<glommer@redhat.com>
> ---
> arch/x86/include/asm/kvm_para.h | 5 +++++
> arch/x86/include/asm/pvclock-abi.h | 1 +
> arch/x86/kernel/kvmclock.c | 3 +++
> arch/x86/kernel/pvclock.c | 4 ++++
> 4 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
> index f019f8c..6f1b878 100644
> --- a/arch/x86/include/asm/kvm_para.h
> +++ b/arch/x86/include/asm/kvm_para.h
> @@ -21,6 +21,11 @@
> */
> #define KVM_FEATURE_CLOCKSOURCE2 3
>
> +/* The last 8 bits are used to indicate how to interpret the flags field
> + * in pvclock structure. If no bits are set, all flags are ignored.
> + */
> +#define KVM_FEATURE_CLOCKSOURCE_STABLE_TSC 24
>
This needs documentation (in cpuid.txt). The flag doesn't mean the TSC
is stable, rather it means the pvclock tsc stable bit is valid.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-05-05 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 15:52 [PATCH v2 0/7] Pvclock fixes , version two Glauber Costa
2010-05-03 15:52 ` [PATCH v2 1/7] Enable pvclock flags in vcpu_time_info structure Glauber Costa
2010-05-03 15:52 ` [PATCH v2 2/7] Add a global synchronization point for pvclock Glauber Costa
2010-05-03 15:52 ` [PATCH v2 3/7] change msr numbers for kvmclock Glauber Costa
2010-05-03 15:52 ` [PATCH v2 4/7] export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID Glauber Costa
2010-05-03 15:52 ` [PATCH v2 5/7] Try using new kvm clock msrs Glauber Costa
2010-05-03 15:52 ` [PATCH v2 6/7] don't compute pvclock adjustments if we trust the tsc Glauber Costa
2010-05-03 15:52 ` [PATCH v2 7/7] Tell the guest we'll warn it about tsc stability Glauber Costa
2010-05-05 8:28 ` Avi Kivity [this message]
2010-05-05 8:23 ` [PATCH v2 4/7] export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID Avi Kivity
2010-05-05 8:29 ` [PATCH v2 1/7] Enable pvclock flags in vcpu_time_info structure Avi Kivity
2010-05-05 3:57 ` [PATCH v2 0/7] Pvclock fixes , version two Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE12C1B.8070409@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox