From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM MMU: fix for forgot mark parent->unsync_children bit Date: Wed, 05 May 2010 15:30:17 +0300 Message-ID: <4BE164D9.2030301@redhat.com> References: <4BE16265.7060004@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , KVM list , LKML To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090Ab0EEMaX (ORCPT ); Wed, 5 May 2010 08:30:23 -0400 In-Reply-To: <4BE16265.7060004@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/05/2010 03:19 PM, Xiao Guangrong wrote: > When mapping a new parent to unsync shadow page, we should mark > parent's unsync_children bit > > Reported-by: Marcelo Tosatti > Signed-off-by: Xiao Guangrong > --- > arch/x86/kvm/mmu.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 97f2ea0..bf35a2f 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -1374,7 +1374,9 @@ static struct kvm_mmu_page *kvm_mmu_get_page(struct kvm_vcpu *vcpu, > if (sp->unsync_children) { > set_bit(KVM_REQ_MMU_SYNC,&vcpu->requests); > kvm_mmu_mark_parents_unsync(sp); > - } > + } else if (sp->unsync) > + kvm_mmu_mark_parents_unsync(sp); > + > trace_kvm_mmu_get_page(sp, false); > return sp; > } > Which patch does this fix? If it wasn't merge yet, please repost with the fix included. -- error compiling committee.c: too many arguments to function