From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH 2/2] KVM MMU: fix race in invlpg code
Date: Wed, 05 May 2010 20:45:33 +0800
Message-ID: <4BE1686D.9000902@cn.fujitsu.com>
References: <4BE16265.7060004@cn.fujitsu.com> <4BE162B9.201@cn.fujitsu.com> <4BE1650B.7080809@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	KVM list <kvm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:54187 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S934492Ab0EEMso (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 5 May 2010 08:48:44 -0400
In-Reply-To: <4BE1650B.7080809@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



Avi Kivity wrote:

>>       spin_lock(&vcpu->kvm->mmu_lock);
>> +    index = kvm_page_table_hashfn(gfn);
>> +    bucket =&vcpu->kvm->arch.mmu_page_hash[index];
>> +    hlist_for_each_entry_safe(s, node, tmp, bucket, hash_link)
>> +        if (s == sp) {
>> +            if (s->gfn == gfn&&  s->role.word == role.word)
>> +                live = true;
>> +            break;
>> +        }
>> +
>> +    if (!live)
>> +        goto unlock_exit;
>> +
>>    
> 
> Did you try the root_count method?  I think it's cleaner.

Avi, Thanks for your idea.

I have considered this method, but i'm not sure when it's the good time
to real free this page, and i think we also need a way to synchronize the
real free path and this path. Do you have any comment for it :-(

Xiao