From: Naphtali Sprei <nsprei@redhat.com>
To: kvm@vger.kernel.org
Cc: Avi Kivity <avi@redhat.com>
Subject: [qemu-kvm tests PATCH v2] qemu-kvm tests: fix linker script problem
Date: Wed, 05 May 2010 16:53:00 +0300 [thread overview]
Message-ID: <4BE1783C.6050202@redhat.com> (raw)
commit 848bd0c89c83814023cf51c72effdbc7de0d18b7 causes the linker script
itself (flat.lds) to become part of the linked objects, which messed
the output file, specifically, the symbol edata is not the last symbol
anymore.
change v1 -> v2
Instead of dropping the dependency, put it on a separate line/rule, so the
lds file will not be considered as one of the dependencies in the linking line/rule.
Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
---
kvm/user/config-x86-common.mak | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kvm/user/config-x86-common.mak b/kvm/user/config-x86-common.mak
index 61cc2f0..241c422 100644
--- a/kvm/user/config-x86-common.mak
+++ b/kvm/user/config-x86-common.mak
@@ -19,7 +19,8 @@ CFLAGS += -m$(bits)
libgcc := $(shell $(CC) -m$(bits) --print-libgcc-file-name)
FLATLIBS = test/lib/libcflat.a $(libgcc)
-%.flat: %.o $(FLATLIBS) flat.lds
+%.flat: flat.lds
+%.flat: %.o $(FLATLIBS)
$(CC) $(CFLAGS) -nostdlib -o $@ -Wl,-T,flat.lds $^ $(FLATLIBS)
tests-common = $(TEST_DIR)/vmexit.flat $(TEST_DIR)/tsc.flat \
--
1.6.3.3
next reply other threads:[~2010-05-05 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 13:53 Naphtali Sprei [this message]
2010-05-05 15:05 ` [qemu-kvm tests PATCH v2] qemu-kvm tests: fix linker script problem Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE1783C.6050202@redhat.com \
--to=nsprei@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox