From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] KVM: X86: add the support of XSAVE/XRSTOR to guest Date: Thu, 06 May 2010 22:49:09 +0300 Message-ID: <4BE31D35.7050802@redhat.com> References: <1272518554-20357-1-git-send-email-dexuan.cui@intel.com> <4BDD8896.2000607@redhat.com> <1865303E0DED764181A9D882DEF65FB61A82B51D4A@shsmsx502.ccr.corp.intel.com> <4BE27A5A.2020903@redhat.com> <1865303E0DED764181A9D882DEF65FB61A82B51D4C@shsmsx502.ccr.corp.intel.com> <4BE31C43.9060506@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , "Yang, Sheng" To: "Cui, Dexuan" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21758 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757075Ab0EFTtM (ORCPT ); Thu, 6 May 2010 15:49:12 -0400 In-Reply-To: <4BE31C43.9060506@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/06/2010 10:45 PM, Avi Kivity wrote: > > All those control registers are annoying, we have cr1 and cr5-cr7 > free, cr9-cr15 on x86_64, infinite msr space, and now we have XCRs. > Great. > > Looking forward to YCR0. > I think I see the reason - xgetbv is unprivileged, so applications can see what the OS supports instead of looking at cpuid and hoping. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.