From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v5 3/5] Add functions for assigning ioeventfd and irqfds.
Date: Mon, 10 May 2010 13:43:19 +0300
Message-ID: <4BE7E347.9050705@redhat.com>
References: <1271872408-22842-1-git-send-email-cam@cs.ualberta.ca> <1271872408-22842-2-git-send-email-cam@cs.ualberta.ca> <1271872408-22842-3-git-send-email-cam@cs.ualberta.ca> <1271872408-22842-4-git-send-email-cam@cs.ualberta.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
To: Cam Macdonell <cam@cs.ualberta.ca>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49730 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752849Ab0EJKnW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 10 May 2010 06:43:22 -0400
In-Reply-To: <1271872408-22842-4-git-send-email-cam@cs.ualberta.ca>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/21/2010 08:53 PM, Cam Macdonell wrote:
> Generic functions to assign irqfds and ioeventfds.
>
>    

Signoff.

>   }
>
>   #ifdef KVM_IOEVENTFD
> +int kvm_set_irqfd(int fd, uint16_t vector, uint32_t gsi)
> +{
> +    struct kvm_irqfd call = { };
> +    int r;
> +
> +    call.fd = fd;
> +    call.gsi = gsi;
>    

> +
> +    if (!kvm_enabled())
> +        return -ENOSYS;
>    

Braces, here and elsewhere.

> +    r = kvm_vm_ioctl(kvm_state, KVM_IRQFD,&call);
> +
> +    if (r<  0) {
> +        return r;
>    

-errno

> +    }
> +    return 0;
> +}
> +
> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t addr, uint32_t val, bool assign)
> +{
> +
> +    int ret;
> +    struct kvm_ioeventfd iofd;
> +
> +    iofd.datamatch = val;
> +    iofd.addr = addr;
> +    iofd.len = 4;
> +    iofd.flags = KVM_IOEVENTFD_FLAG_DATAMATCH;
> +    iofd.fd = fd;
> +
> +    if (!kvm_enabled())
> +        return -ENOSYS;
> +    if (!assign)
> +        iofd.flags |= KVM_IOEVENTFD_FLAG_DEASSIGN;
>    

May be more usable to have separate assign and deassign functions (that 
can call into a single internal implementation).

> +
> +    ret = kvm_vm_ioctl(kvm_state, KVM_IOEVENTFD,&iofd);
> +
> +    if (ret<  0) {
> +        return ret;
>    

-errno

> +    }
> +
> +    return 0;
> +}
> +
>    

-- 
error compiling committee.c: too many arguments to function