From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v3 0/8] pvclock fixes - v3 Date: Tue, 11 May 2010 11:35:22 +0300 Message-ID: <4BE916CA.6030501@redhat.com> References: <1273094839-18655-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zamsden@redhat.com To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44500 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740Ab0EKIfZ (ORCPT ); Tue, 11 May 2010 04:35:25 -0400 In-Reply-To: <1273094839-18655-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/06/2010 12:27 AM, Glauber Costa wrote: > Hello, > > Avi, this version fixes the issues you raised in the last > review. Hopte it is better now. > > Sorry about the late review. Looks reasonable, apart from a couple of minor points. > A cpuid.txt wil follow as soon as we're set on everything, so > I am not including it yet. > Pity, for a reviewer it is a lot easier to review a spec, then the code's conformity to the spec, instead of having to reverse engineer the intent from the code. Please include it next time. -- error compiling committee.c: too many arguments to function